Skip to content

feat(ChartList): Better (relative) paths in chart links#113

Merged
sjockers merged 3 commits into
mainfrom
feat/chartlist-rel-external
Aug 5, 2025
Merged

feat(ChartList): Better (relative) paths in chart links#113
sjockers merged 3 commits into
mainfrom
feat/chartlist-rel-external

Conversation

@sjockers
Copy link
Copy Markdown
Contributor

@sjockers sjockers commented Aug 4, 2025

  • Use relative paths to charts (also works in PR previews, no resolve necessary)
  • Use rel=external to disable clientside routing
  • Add .html prefix to embed URL, even when baseUrl is not set

@sjockers sjockers requested a review from awesomephant August 4, 2025 13:00
@awesomephant
Copy link
Copy Markdown
Collaborator

Use rel=external to disable clientside routing

docs for future ref

Copy link
Copy Markdown
Collaborator

@awesomephant awesomephant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjockers sjockers merged commit 3f48d66 into main Aug 5, 2025
1 check passed
@sjockers sjockers deleted the feat/chartlist-rel-external branch August 5, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants